Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for JSON files describing commands metadata #202

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Better support for JSON files describing commands metadata #202

merged 4 commits into from
Feb 19, 2024

Conversation

zuiderkwast
Copy link
Collaborator

  • Improved JSON 'arguments' fallback in gencommand.py
  • Update generated command table from latest Redis
  • Support the output of redis utils/generate-commands-json.py
  • Update comments in gencommands.py about the JSON file format

bjosv
bjosv approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good comments about find_keys differences.

@zuiderkwast zuiderkwast merged commit 88f9487 into Nordix:master Feb 19, 2024
32 checks passed
@zuiderkwast
Copy link
Collaborator Author

Good comments about find_keys differences.

THanks. What abour "keynum"? It's the same difference. I didn't want to repeat the code logic in the comments though.

@zuiderkwast zuiderkwast deleted the better-json branch February 19, 2024 14:11
@bjosv
Copy link
Collaborator

bjosv commented Feb 19, 2024

THanks. What abour "keynum"? It's the same difference. I didn't want to repeat the code logic in the comments though.

I think its fine with the added comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjosv bjosv bjosv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuiderkwast @bjosv