-
Notifications
You must be signed in to change notification settings - Fork 220
Added Privacy Manifest for both Library and Example App #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The APIs accessed are really under the purview of the ZIP Foundation library the library itself uses. But given that we might rely on older versions of library dependencies for the sake of convenience & compatibility (until something breaks), I thought it was prudent to add it ourselves as part of what our library does. After all, if we drop ZIPFoundation it's up to us, as library providers, to pick up the slack.
Could you remove the 2 reasons and add only one:
|
Also, for the App I think we need to add User Default APIs with the reason
We're not using IOS-DFU-Library/App/dfu/viewmodel/DfuViewModel.swift Lines 46 to 65 in 4f9db20
|
Also, @dinesharjani, is it the right place to put the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above.
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add NSPrivacyAccessedAPIType
with type "User defaults APIs" and reason CA92.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see UserDefaults used by DFU Example App. It's used by McuManager Example app. But if you want me to, I'll add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, the app is using @AppStorage
properties.
It was not picked up by Git if I put it in a folder. I don't know the specifics of what the .gitignore or whatever rules are, so I put it in the root folder like Apple recommended. |
The APIs accessed are really under the purview of the ZIP Foundation library the library itself uses. But given that we might rely on older versions of library dependencies for the sake of convenience & compatibility (until something breaks), I thought it was prudent to add it ourselves as part of what our library does. After all, if we drop ZIPFoundation it's up to us, as library providers, to pick up the slack.