Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making CBMDictionary explicitly internal #118

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Making CBMDictionary explicitly internal #118

merged 3 commits into from
Mar 11, 2025

Conversation

philips77
Copy link
Member

@philips77 philips77 commented Mar 10, 2025

This PR changes the access modifier of the new CBMDictionary class to internal.
The class was added in #115.

@nathandud
Copy link
Contributor

I had to double check but the Apple Docs specify that internal is the default access control level if not specified. However, I looked over the rest of the internal classes (CBMCharacteristicNative,
CBMDescriptorNative) and since they are all explicit about being internal, I think it's the correct move here.

@philips77 philips77 changed the title Making CBMDictionary internal Making CBMDictionary explicitly internal Mar 11, 2025
@philips77
Copy link
Member Author

Yes, you're right. I forgot. And that's also why I try always to write the modifier explicitly. In Kotlin the default is public, so it's better to always write it.

@philips77 philips77 merged commit 4893475 into main Mar 11, 2025
1 check passed
@philips77 philips77 deleted the improvement/dict branch March 11, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants