request mtu in Legacy #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
Hi, did you modify the bootloader to support higher MTUs? MTU > 23 is only supported in the official Secure DFU from SDK 15 onwards. |
Contributor
Author
|
Hi, we use Nordic hardware on a few of our products & built a mobile SDK that uses this library. In order to maintain a consistent mobile SDK across multiple products we ported the Legacy mechanism to different FW SDKs that support a higher mtu. |
Merged
mormegil-cz
added a commit
to mormegil-cz/Gadgetbridge
that referenced
this pull request
Aug 17, 2023
Now that the target SDK was changed to 31, the `no.nordicsemi.android:dfu` library needs to be updated, as the current version dies on Android 12+. However, the fixed version (1.12.0) also fixed MTU handling: The previous versions ignored the MTU settings completely for legacy DFU. <NordicSemiconductor/Android-DFU-Library#260> And while our `PineTimeJFSupport` code always tried to set MTU to 517, it was ignored. Which was good because PineTime does not support larger MTUs. So that we need to set the correct low MTU now the library really applies it. Note that the current version of the DFU library cannot be used right now, it does not even compile because of androidx dependency mismatch. Fixes #3203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to support adjusting the MTU for Legacy Dfu. Currently if the Dfu is set on the DfuServiceInitiator it is ignored.