-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Feature/create ahk run configs #15
[READY] Feature/create ahk run configs #15
Conversation
…sic ahk execution working with this commit. Preliminary support for AHK sdk also added
… script to execute
…ecuting run config. Set up run config to use Sdk path for execution.
…hkRunConfigSettingsEditor label text
…sses to be used later. Updated README.md
…ipt execution. Did some refactoring to make the command line code easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to auto-detect the script path using the open file? I saw other languages do it but I am not sure how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also possible to instead of opening the warning to set the sdk open a dialog to set it? (Not sure if possible but would be nice if it is. Kind of thinking out loud).
I will look into this. There needs to be some kind of error alert shown to the user (otherwise the user has no idea why the Sdk dialog opened); using a message dialog is the easiest way to show it. Eventually this error code will be deleted in a future release once an Sdk selector is added inside the run config itself (like what the Python plugin has). |
… receiving popup will also open up project structure window. Also added simple junit test to verify testing is possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi mtrnord, this PR fixes the run config functionality so that we can run AHK scripts via a run config. Basically you just create a new AutoHotkey SDK and then set that for the project, and then any scripts that are run will use that SDK.
I have also updated the plugin's compatible build range in the build script to include everything from 2019.3 to 2020.1.
(Assuming everything looks good, I would like to update the release version to 0.2.0 and push that to JetBrains with this new stuff.)