Emit Android min SDK 24 compatible code for Timestamp and Duration #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTimeException requires min SDK 26, but our applications require min SDK 24.
arg0d
changed the title
arg0d
force-pushed
the
kristupas/target-min-android-24
branch
from
0ab70b2
to
749b625
Compare
Lipt0nas
approved these changes
May 3, 2024
|
Though in seriousness, im not sure if this actually passes a breaking change threshold, since someone that would have been relying on |
|
I'm not sure either. In my mind, this is not an exception that you would normally try to handle. These exceptions would only happen when trying to pass negative timestamp/duration values into the bindings, which I think indicates a programming error, and not an error that the code should attempt to recover from. But maybe I'm wrong :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeException requires min SDK 26, but our applications require min SDK 24.