Add support for OSX #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBelloni
force-pushed
the
osx-support
branch
from
d9d1541 to
4df5a27
Compare
added 3 commits
October 10, 2024 18:35
Signed-off-by: Christian Belloni <christianbelloni@Christians-Laptop.local>
Signed-off-by: Christian Belloni <christianbelloni@Christians-Laptop.local>
Signed-off-by: Christian Belloni <christianbelloni@Christians-Laptop.local>
ChristianBelloni
force-pushed
the
osx-support
branch
from
e71579c to
8f6f737
Compare
arg0d
requested changes
Oct 11, 2024
Signed-off-by: Christian Belloni <christianbelloni@Christians-Laptop.local>
arg0d
approved these changes
Nov 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a naive implementation to support osx, for what i can see on every other platform everything should stay the same and all tests now pass, let me know if there's something else i should do