fix: test using utc time #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTime always defaults to local time and needs to be explicitly converted to utc. Signed-off-by: Samuel Meenzen <samuel@meenzen.net>
|
This only fixes the symptoms of the issue so I created #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTime always defaults to local time and needs to be explicitly converted to UTC.
The tests fail if the system timezone is not set to UTC. Because GitHub Actions use UTC by default this was not caught by CI.
Warning: Do not merge unless this behavior is intended!
I don't quite understand how DateTime conversion works. To me it looks like TimeStampHelper.cs assumes that passed DateTime values are always UTC, which is not the case.
The current implementation might not be sufficient.