LLT-5197: Make backup of events db in natlab before copying #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our tests, we were copying the original events db from the container to the host when checking for events. This way of doing it wouldn't take into account in-progress writes or other reasons why the db might be locked. As a way to get around it, we now let sqlite create a backup first, which does respect the db potentially being locked, and then we copy the backup
mathiaspeters
force-pushed
the
LLT-5197_proper_moose_events_file_backup
branch
from
6d11518 to
5e8c512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For our tests, we were copying the original events db from the container to the host when checking for events. This way of doing it wouldn't take into account in-progress writes or other reasons why the db might be locked and sometimes led to the copied db being corrupted
Solution
As a way to get around it, we now let sqlite create a backup first, which does respect the db potentially being locked, and then we copy the backup
☑️ Definition of Done checklist