A few improvements, mostly for user-provided configuration #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
If the `$HOME/.config/charpicker/theme.rasi` is available, use it for the rofi theme instead of local `arthur-c.rasi` to allow the user to control the style. Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
This patch adds support for user symbols. Those symbols are added to the project's provided symbol list, as explained in `README.md`. The purpose of this feature is for a user to have its own symbols which are not necessarily interesting to the general public while still being able to update the official project's list. The new script, `effective_special_character_list.sh`, outputs the concatenation of the provided list of symbols (`special_character_list`) and the user list of symbols (`~/.config/charpicker/special_character_list`), if any. `compile.sh` and `charpickerprint.sh` use this script instead of reading from `special_character_list` directly. Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
|
Looks great, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages and the updated
README.mdfor details.