update noresm2_3_deveop for noresm2_1_develop compatibility #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstants from const.F90
… chemistry/oslo_aero
…duplicate files and refactored seasalt_model
mvertens
changed the title
gold2718
force-pushed
the
noresm2_3_develop
branch
from
3cf4116
to
bda7c1b
Compare
|
This work was incorporated into noresm2_3_develop vi bda7c1b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: updates of how shadow files are handled for oslo_aero
Contributors: mvertens
Reviewers: gold2718
Purpose of changes: Updates for consistency with noresm2_5_develop as well as refactoring of non oslo-aero code in order to not have #ifdef OSLO_AERO - but be the original code. The #ifdefs should only be contained in the shadow files in oslo_aero/src_cam
Github PR URL: #130
Changes made to build system: None
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None (did not measure though)
Issues addressed by this PR: #131