Upgrade timing #682
Open
Upgrade timing #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasTorsvik
approved these changes
Nov 3, 2025
milicak
approved these changes
Nov 3, 2025
JorgSchwinger
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the timing of various tasks is cumbersome to maintain and extend. Further, it only provides timing statistics of the master process, which might not give reliable results in parallel execution. This PR simplifies the interface to the timing module, which now handles all the bookkeeping and statistical output of various timers. During parallel execution, timers for all processes are now active allowing for more reliable timing statistics. The timing of various tasks during a BLOM time step has been revised and, particularly when the ALE method is used, more precise timing statistics are provided.
This PR does not change results and only modifies time statistics to stdout (ocn.log.* in NorESM).