-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining copyright notices, LGPL license and some code cleanup #6
Conversation
…license situation, no MPI parallelization, no support for tripolar grids and limited use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I noticed you use the f90 comment style throughout ('!' instead of 'c'), but this should still work for fixed-form files when inserted in the first column. Otherwise I don't have any specific comments.
@matsbn I linked the license issue to this pull request, so the issue should be closed once the pull request is merged. The assignees are the ones who should sign off on the pull request. At the moment I have an option to merge the pull request, and I guess all blom-core members have this option, but I'm not going to "pull the trigger" on anything that I'm not assigned to. You can probably assign it to anyone you like, including yourself, but I think it is more tidy if it is made clear who will have the last word on the merging. |
Good idea to suggest reviewers. Pull requests is still new to me so I need to improve on proper handling of things like this. I chose f90 comment style since the plan is anyway to modernise the f77 style code. I have checked that it compiles fine with gcc and intel compilers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me.
Inserted copyright/license notice in remaining files. Removed dynamic sea-ice code and some obsolete files. Added GPL and LGPL license files and updated README.md with license information.