Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining copyright notices, LGPL license and some code cleanup #6

Merged
merged 7 commits into from
Apr 22, 2020

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Apr 21, 2020

Inserted copyright/license notice in remaining files. Removed dynamic sea-ice code and some obsolete files. Added GPL and LGPL license files and updated README.md with license information.

@TomasTorsvik TomasTorsvik self-requested a review April 21, 2020 17:19
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I noticed you use the f90 comment style throughout ('!' instead of 'c'), but this should still work for fixed-form files when inserted in the first column. Otherwise I don't have any specific comments.

@TomasTorsvik TomasTorsvik linked an issue Apr 21, 2020 that may be closed by this pull request
@TomasTorsvik
Copy link
Contributor

@matsbn
I think it would be a good idea if you suggest reviewers and assignees for this pull request. If the pull request is connected to an open issue, I suggest the people who have commented on the issue could be invited to review the changes. Perhaps this is not practical if a lot of people have been involved in a discussion, but I don't think it can do any harm to invite people to review.

I linked the license issue to this pull request, so the issue should be closed once the pull request is merged.

The assignees are the ones who should sign off on the pull request. At the moment I have an option to merge the pull request, and I guess all blom-core members have this option, but I'm not going to "pull the trigger" on anything that I'm not assigned to. You can probably assign it to anyone you like, including yourself, but I think it is more tidy if it is made clear who will have the last word on the merging.

@matsbn
Copy link
Contributor Author

matsbn commented Apr 21, 2020

Good idea to suggest reviewers. Pull requests is still new to me so I need to improve on proper handling of things like this. I chose f90 comment style since the plan is anyway to modernise the f77 style code. I have checked that it compiles fine with gcc and intel compilers.

Copy link
Collaborator

@mvhulten mvhulten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

@matsbn matsbn merged commit 56d027d into NorESMhub:master Apr 22, 2020
@matsbn matsbn deleted the feature-blom-lgpl branch April 22, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License for BLOM
4 participants