Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified setting of vertical coordinate and vertical dimension #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Aug 21, 2024

This is just a draft PR for making hybrid vertical coordinate selectable as compset option and defining vertical dimension in env_build.xml.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I see this PR changes loading of M4AGO, so I suggest @jmaerz should have a look at it before merging.

@matsbn
Copy link
Contributor Author

matsbn commented Aug 22, 2024

Looks fine to me. I see this PR changes loading of M4AGO, so I suggest @jmaerz should have a look at it before merging.

Current master fails to build in NorESM2.0.* if iHAMOCC is not requested. The buildlib_2.1 was made consistent with what is already done in buildlib_2.2 (2a0d544). That is, iHAMOCC and M4AGO should only be built if ocean biogeochemistry is requested. Could be made as a separate bugfix PR, but I just discovered it when testing this new functionality.

@matsbn matsbn added the enhancement New feature or request label Aug 22, 2024
Copy link
Collaborator

@jmaerz jmaerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matsbn , thanks for catching this (and sorry for introducing it wrongly at first place). As far as I understand, the updated file solves the compilation issue with both, ecosys on or off. Hence, I am happy to approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants