Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging master into feature-hamocc_beyond-CMIP6 #268

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Aug 9, 2023

Once the recent master has been tested by @matsbn to be compatible with the MCT driver, it can be merged into the feature-hamocc_beyond-CMIP6 branch.

mvertens and others added 11 commits July 14, 2023 13:47
add BLOM regression test functionality
…ixed 1D box atmosphere for air-sea exchange of CO2 (and C-isotopes). There is currently no way to activate this option other than adding the preprocessor flag -DBOXATM in cime_config/buildcpp.
…ed technically but not validated, build script will still refuse to run this combination of options)
* renaming beleg_parm to mo_parambgc_ini without any further changes - not executable

* adjust description to new module name

* adjust description

* initial step to rewrite mo_parambgc_ini to real module - compilable

* Restructuring mo_parambgc_ini

* Placing the nml-read call

* First working namelist read for BGC parameters

* Re-arrange parameter initialization and tidy up a bit

* add the namelist to the cime config buildnml file - for expert use only

* Add missing parameters to the log-writing subroutine

* Declare local parameters for cisonew

* Remove unused parameter

* fix compile error wrt AGG=true

* Add typical tuning parameters to namelist and introduce readjust routine for parameters that depend on tuning parameters

* add white space

* add Martin curve sinking parameters to bgc-namelist

* Add information to NML-readme file

* Remove old attached version of beleg_parm

* Cleaning write of parameters

* add some white space

* rename mo_parambgc_ini

* Adjust files to new name
@jmaerz jmaerz added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Aug 9, 2023
@jmaerz jmaerz self-assigned this Aug 9, 2023
@jmaerz jmaerz changed the title Merging master into fetaure-hamocc_beyond-CMIP6 Merging master into feature-hamocc_beyond-CMIP6 Aug 9, 2023
@jmaerz
Copy link
Collaborator Author

jmaerz commented Aug 22, 2023

BLOM master still compiles successfully within the NorESM 2.0.6 environment, so I would like to merge the master into the beyond-CMIP6 branch to keep it up-to-date and to enable bringing in the iHAMOCC nml-read changes for tuning parameters into my own branch.

@jmaerz jmaerz marked this pull request as ready for review August 22, 2023 12:36
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaerz - thanks for checking! I think you can go ahead with the merging.

@jmaerz jmaerz merged commit 8690509 into feature-hamocc_beyond-CMIP6 Aug 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants