Removed OMP in pressure calculation to avoid race condition #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JorgSchwinger, Tomas and I, we yesterday identified a potential race condition that (among others) causing issues when running BLOM/iHAMOCC in single column mode. Further places in iHAMOCC seem to be in
ocprod
(settling routine - potential race condition due tok
versuskdonor
?) and incarchm
(to be checked). In this PR, I only addressed the pressure calculation. Currently, single column mode withmaster
is only advisable with flag-D openmp=disabled
to get reproducible results.