Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid coordinate enhancements #235

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

matsbn
Copy link
Contributor

@matsbn matsbn commented Feb 8, 2023

Hybrid coordinate enhancements that includes: Separate non-local terms for vertical distribution of surface temperature restoring flux, surface salinity restoring flux and brine flux; Gradual change of layer thickness in a transition zone separating interfaces with constant pressure and constant potential density, respectively; Submesoscale eddy-induced transport parameterization for hybrid vertical coordinate.

CI issues on macOS have been fixed.

Model results change when using hybrid coordinate, but are unchanged with isopycnic coordinate.

set NIWGF = .4
set SMTFRC = .false.
if ($BLOM_VCOORD == isopyc_bulkml) then
set CE = .5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that CE is undefined if $BLOM_VCOORD /= isopyc_bulkml? Is that ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CE is first set to a common literature value of 0.06 (Fox-Kemper et al., 2008), then adjusted (quite strongly) if $BLOM_VCOORD == isopyc_bulkml. With hybrid coordinate we found reasonable submesoscale eddy-induced overturning strength with the standard value.

Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I can't review any details here.

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any red flags, so it looks fine to me as well.

@matsbn matsbn merged commit 8c04e63 into NorESMhub:master Feb 17, 2023
@matsbn matsbn deleted the feature-hybrid_enhancements branch May 24, 2023 22:16
jmaerz pushed a commit to jmaerz/BLOM that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants