temporary fix for batchRequest #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxc20060903
force-pushed
the
jack/metamask-7.7-fix
branch
from
dc4f6a0
to
5bec49e
Compare
hxc20060903
force-pushed
the
jack/metamask-7.7-fix
branch
from
5bec49e
to
bf9d2e0
Compare
rnons
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct me if I am making it wrong or worse.
Yesterday, MetaMask has just released version 7.7 and it seems the new release is not compatible with BatchReqest.
ethereum/EIPs#2319 (comment)
I checked the code a little bit. MetaMaskInPageProvider used to call sendAsync kind of directly, So I think we still need that feature when it comes to batchRequest.
Hence the change.
BTW, I also heard that even sendAsync would be superseded by send().