Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to recalculate blue channel for prenormalized bc5 normals #59

Open
Nominom opened this issue Mar 17, 2022 · 2 comments · May be fixed by #67
Open

Add option to recalculate blue channel for prenormalized bc5 normals #59

Nominom opened this issue Mar 17, 2022 · 2 comments · May be fixed by #67
Labels
enhancement New feature or request

Comments

@Nominom
Copy link
Owner

Nominom commented Mar 17, 2022

B = sqrt(1 - (sqrt(R) + sqrt(G)))
@Nominom Nominom added the enhancement New feature or request label Mar 17, 2022
@ptasev
Copy link
Contributor

ptasev commented May 20, 2022

Is this the right equation? I thought it would be $R^2 + G^2 + B^2 = 1^2$, which turns into $B = \sqrt{1 - R^2 - G^2}$.

@Nominom
Copy link
Owner Author

Nominom commented May 20, 2022

It should indeed be (R² + G²) instead of (sqrt(R) + sqrt(G)). 🦊 Thanks for double checking!

@EonZeNx EonZeNx linked a pull request Nov 24, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionally regenerate BC5 blue channel when decoding EonZeNx/BCnEncoder.NET
2 participants
@Nominom @ptasev