Merged
Conversation
Exaxxion
force-pushed
the
icon-set-overhaul
branch
3 times, most recently
from
8760cfd to
826c180
Compare
Exaxxion
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Overhauls the way icon sets work by carrying over the addition of inheritance from GTCEu. By allowing an icon set to inherit existing models/textures recursively, a very large amount of redundant data (~700KB) can be removed from the final jar.
Additional info:
A new icon set
CERTUShas been added that is identical toQUARTZbut with the certus quartz texture from GTCEu.A handful of materials have had their icon set/color changed to reflect the way they look in GTCEu.
The following materials have been tweaked:
Possible compatibility issue:
MaterialIconSetto be an enum may have compatibility issues.