Invalidate cache itemstack and state after failed recipe completion#14
Merged
Invalidate cache itemstack and state after failed recipe completion#14
Conversation
ALongStringOfNumbers
force-pushed
the
compressor
branch
from
11b7e13 to
633b5fc
Compare
Exaxxion
reviewed
Aug 1, 2021
Exaxxion
left a comment
Exaxxion
left a comment
There was a problem hiding this comment.
Changes look fine, having some weird issues with the runClient target in my local dev environment so would appreciate if someone can also verify the changes in game.
|
i can? release? |
NotMyWing
pushed a commit
that referenced
this pull request
Jun 3, 2023
Co-authored-by: DStrand1 <DStrand1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple changes related to #7
First, delay the recipe lookup until after there is confirmed to be a non-null item. Previously the recipe lookup would run before a guaranteed item was found, which means that
recipewould always be null, even if the input check found an applicable item.This change defers the recipe lookup to after finding an item, so that
recipewill not be null (for an input item) after the new input item is set.Secondly, if the input consumption failed due to null recipe or other factor, reset the cached itemstack and the mark state. This part is what addresses the issue in #7.
Fixes #7