Don't parse the build info to get the solc version #7186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6682140 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes build info processing by extracting Solidity compiler versions from build info IDs using regex pattern matching instead of reading and parsing the entire build info JSON files.
- Eliminates unnecessary file I/O operations by parsing version information from build info ID format
- Adds regex pattern matching to extract Solidity version components from build info IDs
- Includes proper handling for non-Hardhat generated build infos by filtering them out
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| v-next/hardhat/src/internal/builtin-plugins/solidity-test/edr-artifacts.ts | Replaces file parsing with regex extraction of Solidity versions from build info IDs |
| .changeset/silent-jobs-wash.md | Documents the performance optimization in the changelog |
v-next/hardhat/src/internal/builtin-plugins/solidity-test/edr-artifacts.ts
Show resolved
Hide resolved
v-next/hardhat/src/internal/builtin-plugins/solidity-test/edr-artifacts.ts
Show resolved
Hide resolved
antico5
approved these changes
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.