Skip to content

Re-enable integration tests for ignition #7066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kanej merged 17 commits into from
Jul 30, 2025
Merged

Re-enable integration tests for ignition #7066

kanej merged 17 commits into from
Jul 30, 2025

Conversation

@zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Jul 25, 2025

resolves #6293

Note: this PR's base is not set to v-next as it depends on the code in the migrate task PR to be merged first.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5b01559

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zoeyTM zoeyTM requested a review from kanej July 25, 2025 08:08
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jul 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

hardhat

Total size of the bundle: 54M
Total number of dependencies (including transitive): 38

List of dependencies (sorted by size) 
48M	total
20M	esbuild
7.2M	@sentry/core
5.2M	zod
2.7M	micro-eth-signer
1.9M	@noble/curves
1.7M	undici
1.2M	@noble/hashes
864K	@streamparser/json
860K	@nomicfoundation/hardhat-utils
624K	micro-packed
592K	tsx
544K	fast-equals
516K	@nomicfoundation/hardhat-errors
492K	@scure/bip39
432K	@nomicfoundation/edr
408K	json-stream-stringify
368K	ethereum-cryptography
332K	@streamparser/json-node
320K	enquirer
288K	semver
200K	ws
168K	@scure/base
136K	get-tsconfig
136K	adm-zip
96K	@scure/bip32
92K	chalk
72K	@nomicfoundation/solidity-analyzer
68K	debug
64K	@nomicfoundation/hardhat-zod-utils
56K	rfdc
48K	ansi-colors
44K	resolve.exports
40K	resolve-pkg-maps
36K	p-map
24K	strip-ansi
24K	env-paths
24K	ansi-regex
20K	ms

@zoeyTM zoeyTM force-pushed the ignition/integration-tests branch from 56550d7 to b472bc1 Compare July 25, 2025 08:09
@zoeyTM zoeyTM force-pushed the ignition/integration-tests branch from b472bc1 to 8fab9f4 Compare July 25, 2025 08:10
zoeyTM and others added 3 commits July 25, 2025 04:24
@zoeyTM
Create spicy-grapes-eat.md
c077d33
@kanej
refactor: move folder to remove new-execution
654927a
@kanej
chore: rework test command for Ignition core
6ca64c2 
Move `test` command to `test:unit` and change `pnpm test` to invoke both
unit and integrations.

This means both will be run on the CI.
kanej
kanej approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the integration tests to the build. I think we can merge this once the one failing test is fixed.

@zoeyTM zoeyTM force-pushed the ignition/migrate-task branch from 2800d1b to 3637904 Compare July 28, 2025 07:37
@kanej kanej linked an issue Jul 29, 2025 that may be closed by this pull request
Re-enable hardhat-ignition-core network integration tests #6293
Closed
@zoeyTM zoeyTM force-pushed the ignition/migrate-task branch from 6f49b7c to cc60c31 Compare July 30, 2025 07:24
@kanej kanej added the no changeset needed This PR doesn't require a changeset label Jul 30, 2025
Base automatically changed from ignition/migrate-task to v-next July 30, 2025 23:02
@kanej kanej enabled auto-merge July 30, 2025 23:34
@kanej kanej added this pull request to the merge queue Jul 30, 2025
Merged via the queue into v-next with commit 218f810 Jul 30, 2025
247 checks passed
@kanej kanej deleted the ignition/integration-tests branch July 30, 2025 23:43
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Jul 30, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kanej kanej kanej approved these changes

Assignees

@kanej kanej

Labels

no changeset needed This PR doesn't require a changeset

Projects

Hardhat
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-enable hardhat-ignition-core network integration tests

3 participants

@zoeyTM @kanej