Ignore test but re-enable Ignition core integration tests #6910
Conversation
|
In the CI use `pnpm test:ci` to run both the unit tests on Ignition core and the integration tests against a local Hardhat network. We force the building of everything before testing Ignition core as the integration tests use Hardhat for the network (but not within the production code).
kanej
force-pushed
the
test/fix-failing-ignition-core-integration-test
branch
from
2a9b953 to
f7196cd
Compare
We want to re-enable this test once the error message has been updated.
kanej
force-pushed
the
test/fix-failing-ignition-core-integration-test
branch
from
631579c to
abda191
Compare
| for (const abiItem of artifact.abi.filter( | ||
| // TODO: bring this test back once EDR has updated the invalid | ||
| // error message error message - I said what I said | ||
| (abi) => abi.name !== "revertWithInvalidErrorMessage" |
There was a problem hiding this comment.
I initially removed the method from the Solidity contract - but that implied fixing up bytecode assertions across the test suite.
| "react-dom": "^18.2.0", | ||
| "react-router-dom": "6.11.0", | ||
| "react-tooltip": "^5.21.4", | ||
| "rimraf": "^3.0.2", |
There was a problem hiding this comment.
This is a fix for npm clean in the ignition ui package.
| "test:build": "tsc --project ./test/", | ||
| "test:coverage": "nyc mocha --recursive \"test/**/*.ts\" \"test-integrations/**/*.ts\"", | ||
| "test:integrations": "mocha --recursive \"test-integrations/**/*.ts\"", | ||
| "pretest:ci": "cd ../.. && pnpm build", |
There was a problem hiding this comment.
I can live with this for v2
kanej
changed the title
kanej
changed the title
There is a failing test in the Ignition core integration tests against the local network. EDR has altered the error message returned when there is a badly encoded error message.
This PR:
I chose to filter rather than remove the Solidity function as I didn't want to alter bytecode across the tests as well.
Note the CI failures are because the toolbox version updates have not been released yet.
Resolves #6908