Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardhat-utils return type improvements #5812

Open
wants to merge 6 commits into
base: v-next
Choose a base branch
from
Open

hardhat-utils return type improvements #5812

wants to merge 6 commits into from

Conversation

schaable
Copy link
Member

@schaable schaable commented Oct 9, 2024 •
edited
Loading

This PR improves the return types of the eth, hex and number modules. It also renames the isHexStringPrefixed function to isPrefixedHexString for consistency and to follow adjective-noun order.

EDIT: Also removed async from toBigInt function.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0dffd4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:35pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Oct 9, 2024
alcuadrado
alcuadrado reviewed Oct 10, 2024
View reviewed changes
v-next/hardhat-utils/src/eth.ts Outdated
@@ -1,19 +1,61 @@
import type { PrefixedHexString } from "./hex.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is starting to have many unrelated things. Maybe we should split it into multiple ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the library linking logic from this PR and will submit it in a follow-up PR.

@schaable schaable changed the title hardhat-utils improvements hardhat-utils return type improvements Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej Awaiting requested review from kanej

@ChristopherDedominici ChristopherDedominici Awaiting requested review from ChristopherDedominici

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on
Projects
Hardhat
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado