Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add doNotUseFetch helper to the test utils #5789

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Sep 27, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

I found it helpful during the draft implementation of #5774.

The idea is to override the global reference to fetch with a function that always throws an error. This is a very crude approach to simulating network connectivity issues when using fetch. We can explore this area further in the future if needed. However, at this time, this met my needs.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 10:36pm

Copy link

changeset-bot bot commented Sep 27, 2024

⚠️ No Changeset found

Latest commit: 6b68734

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Sep 27, 2024
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR, I think I'd just rename the path to /http instead of /global, as it'd be easier to discover in the future.

@alcuadrado
Copy link
Member

alcuadrado commented Sep 30, 2024

Now that I think of, maybe it'd be better to use a linter rule that directs you to the utils package

@alcuadrado alcuadrado self-requested a review September 30, 2024 22:21
@galargh galargh added this pull request to the merge queue Oct 1, 2024
@galargh
Copy link
Member Author

galargh commented Oct 1, 2024

Now that I think of, maybe it'd be better to use a linter rule that directs you to the utils package

Do you mean one that does that when someone tries to overwrite global.fetch directly?

Merged via the queue into v-next with commit ea16594 Oct 1, 2024
57 checks passed
@galargh galargh deleted the galargh/do-not-use-fetch branch October 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants