chore: do not send hardhat_setLedgerOutputEnabled over http #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d144d83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
galargh
force-pushed
the
galargh/set-ledger-output-enabled
branch
from
dbe99af
to
8a96f1d
Compare
galargh
force-pushed
the
galargh/set-ledger-output-enabled
branch
from
8a96f1d
to
6771f00
Compare
alcuadrado
reviewed
Aug 7, 2024
alcuadrado
approved these changes
Aug 7, 2024
schaable
reviewed
Aug 7, 2024
schaable
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5406
The goal of this PR is to suppress
hardhat_setLedgerOutputEnabled - Method not supportedwarnings from the local hardhat node logs. They appear there when one performs a deployment against a node and does not usehardhat-ledgerplugin.The approach presented in this PR is a "quick fix". It assumes that if a message with
hardhat_setLedgerOutputEnabledmethod reaches an HTTP provider, it should be treated as an error and not processed further (otherwise, it would have been consumed by the ledger provider before it could reach the http provider). This ensures that ifhardhat-ledgerplugin is not used, thehardhat_setLedgerOutputEnabledmessage will never reach a running node. Hence, a warning will not be printed out by the node.This is not an ideal solution as it exposes plugin context in the core package further. Some alternatives that I was thinking about in no particular order:
hardhat_setLedgerOutputEnabledat all if a ledger provider is not present in the chain (the challenge being identifying a ledger provider)outputEnableda configuration option of the ledger plugin (I'm not sure whether completely enabling/disabling output is valid for the plugin; during deployment, we only disable it temporarily)