Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch main into v-next to update GitHub Actions #5574

Merged
merged 157 commits into from
Aug 5, 2024

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 5, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR merges the current main into the v-next branch. The intent is to get the recent updates of the GitHub Actions workflows on the v-next branch too. It is a result of running the following commands (writing them out to ensure I'm following the right procedure):

git merge origin/main -X theirs

rm .github/workflows/comment-on-linter-error.yml
rm .github/workflows/hardhat-chai-matchers-ci.yml
rm .github/workflows/hardhat-ethers-ci.yml
rm .github/workflows/hardhat-foundry-ci.yml
rm .github/workflows/hardhat-ledger-ci.yml
rm .github/workflows/hardhat-network-helpers-ci.yml
rm .github/workflows/hardhat-network-tracing-all-solc-versions.yml
rm .github/workflows/hardhat-shorthand-ci.yml
rm .github/workflows/hardhat-toolbox-ci.yml
rm .github/workflows/hardhat-verify-ci.yml
rm .github/workflows/hardhat-viem-ci.yml
rm .github/workflows/hardhat-vyper-ci.yml
rm .github/workflows/hardhat-web3-v4-ci.yml

rm -r packages/hardhat-solhint
rm -r packages/hardhat-truffle5

# Update pnpm-lock.yaml(s)
pushd docs && pnpm install && popd
pnpm install

git add . && git merge --continue

fvictorio and others added 30 commits May 10, 2024 11:37
Add config validation for empty network and forking url
…ssue_#4151

adding a function and editing the error message for the issue #4151
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 5, 2024
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 1:14pm

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 330ce4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 5, 2024
@galargh
Copy link
Member Author

galargh commented Aug 5, 2024

Apart from the merge of main, this PR also fixes issues reported by the linter (after the pnpm install performed as part of the merge?). Have a look at c08e03b and 330ce4e to verify the applied fixes.

@galargh galargh marked this pull request as ready for review August 5, 2024 13:21
@galargh galargh merged commit 5ce208a into v-next Aug 5, 2024
124 checks passed
@galargh galargh deleted the galargh/main-v-next branch August 5, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.