Skip to content

Implement feedback on task, subtask and parameter cli parsing #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristopherDedominici merged 15 commits into from
Jun 4, 2024
Merged

Implement feedback on task, subtask and parameter cli parsing #5300

ChristopherDedominici merged 15 commits into from
Jun 4, 2024

Conversation

@ChristopherDedominici
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici commented May 31, 2024 •
edited
Loading

See the original PR with the comments to implement: #5282.

Every comment is addressing a specific issue raised in the PR linked above.

There are also additional commits to improve a few smaller code parts, but also in this case everything should be quite easy to understand from the commit message

@vercel
Copy link

vercel bot commented May 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:42pm

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cacd27c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChristopherDedominici ChristopherDedominici marked this pull request as ready for review June 3, 2024 15:24
alcuadrado
alcuadrado approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@alcuadrado alcuadrado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

Two comments, which can be addressed on separate PRs:

  1. As discussed, file type should be just string, without any validation.
  2. Flags can have explicit values too, for consistency. e.g. --flag and --flag true are both valid an equivalent.

I think we can merge this PR and address these things on separate PRs.

@ChristopherDedominici ChristopherDedominici merged commit 6413a98 into v-next Jun 4, 2024
@ChristopherDedominici ChristopherDedominici deleted the bug/implemet-feedback-on-task-parsing branch June 4, 2024 08:08
@ChristopherDedominici ChristopherDedominici mentioned this pull request Jun 4, 2024
Closed
@ChristopherDedominici ChristopherDedominici linked an issue Jun 4, 2024 that may be closed by this pull request
Implement and test the parser of task arguments #5288
Closed
@ChristopherDedominici ChristopherDedominici mentioned this pull request Jun 4, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@kanej kanej

Labels

status:triaging

Projects

Hardhat
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement and test the parser of task arguments

4 participants

@ChristopherDedominici @alcuadrado @kanej