fix: use weak references for stored threadsafe functions #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6011166 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Wodann
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
Wodann
commented
Mar 26, 2024
| @@ -0,0 +1,41 @@ | |||
| const edr = require("@nomicfoundation/edr") | |||
There was a problem hiding this comment.
@fvictorio should this file be kept? Feel free to modify this to be automatically testable
There was a problem hiding this comment.
I replaced this with an e2e fixture project. This will fail now because the EDR dependency is not published yet though.
Wodann
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
fvictorio
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Ran some manual tests and it seems to work fine:
- Running a script with
hh run - Running a script with
node --require hardhat/register - Running a script with
node script.js, where the script explicitly requires the HRE - Running
hh test - Running
mocha --require hardhat/register - Running scripts and tests in a typescript project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NomicFoundation/edr#339 & #4997.
In the process of making this fix, I also bumped
napito v2.16.0. As it doesn't affect the generatedindex.d.tsofedr_napi, this can still be considered a patch version bump for EDR.