check for secrets during publishing #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed. I added a dummy env to use in CI tests. |
OmarTawfik
force-pushed
the
update-release-steps
branch
from
8c224cd
to
cbc026a
Compare
|
cc @kanej this should be good to go. please let me know if you have any other suggestions. |
kanej
approved these changes
Sep 16, 2024
OmarTawfik
added a commit
that referenced
this pull request
Sep 26, 2024
* check for secrets during publishing * add a dummy '.env' for packaging * check for secrets during server publishing as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and update the
publish-extension.md.For local development/testing, we can always insert dummy values into the file.