feat: replace slang cursor usage with queries #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarTawfik
reviewed
Jun 5, 2024
OmarTawfik
reviewed
Jun 5, 2024
OmarTawfik
reviewed
Jun 5, 2024
OmarTawfik
reviewed
Jun 5, 2024
OmarTawfik
requested changes
Jun 5, 2024
OmarTawfik
reviewed
Jun 7, 2024
OmarTawfik
approved these changes
Jun 14, 2024
OmarTawfik
pushed a commit
that referenced
this pull request
Jun 28, 2024
* feat: replace slang cursor usage with queries * address PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #547
The usage of queries doesn't seem to affect performance because the cursors were already fast, but it's definitely not a regression and they are much easier to use for what we need. The new code resulted simpler to understand and easier to extend. Specially if we need to make more complex queries in the future.