-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Slang to 0.14.2 #565
Bump Slang to 0.14.2 #565
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@nomicfoundation/slang@0.14.0, npm/@nomicfoundation/solidity-language-server@0.8.2 |
It looks like Add label to new issue is failing again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have pushed what I hope is a fix for the label issue. We will see on your next PR.
Great, thanks! Do I understand correctly that the lockfile version bumps for the extension in b268c5f are expected? I ran If that's expected, it'd be great to merge and release a new extension with it, if that's fine with you 🙏 We'll probably have to look into how we can automate the publishing process, so that it's not on you everytime. Thanks @kanej! |
They are expected. @OmarTawfik and I are planning on a release on Wed 7th May (tomorrow). |
This pulls in support for latest Solidity 0.8.25 and contains a bugfix that allows to correctly parse
f.address
for function pointers in the assembly; other than that, it's passing Sanctuary tests for mainnet and popular L2s like Arbitrum, BSC, Polygon or Optimism.Hopefully this will get rid of the "Unsupported version" errors in Sentry that we were receiving lately; also the language coverage should be fairly complete now.