Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Slang to 0.14.2 #565

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Apr 29, 2024

This pulls in support for latest Solidity 0.8.25 and contains a bugfix that allows to correctly parse f.address for function pointers in the assembly; other than that, it's passing Sanctuary tests for mainnet and popular L2s like Arbitrum, BSC, Polygon or Optimism.

Hopefully this will get rid of the "Unsupported version" errors in Sentry that we were receiving lately; also the language coverage should be fairly complete now.

@Xanewok Xanewok requested a review from kanej April 29, 2024 11:15
Copy link

socket-security bot commented Apr 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/slang@0.14.2 filesystem, shell +9 38.6 MB nomic-foundation-publisher

🚮 Removed packages: npm/@nomicfoundation/slang@0.14.0, npm/@nomicfoundation/solidity-language-server@0.8.2

View full report↗︎

@Xanewok
Copy link
Contributor Author

Xanewok commented Apr 29, 2024

It looks like Add label to new issue is failing again.

@Xanewok Xanewok closed this Apr 29, 2024
@Xanewok Xanewok reopened this Apr 29, 2024
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have pushed what I hope is a fix for the label issue. We will see on your next PR.

@Xanewok
Copy link
Contributor Author

Xanewok commented Apr 30, 2024

Great, thanks!

Do I understand correctly that the lockfile version bumps for the extension in b268c5f are expected? I ran npm install after bumping the slang dep but it looked like the extension version needed updating as well.

If that's expected, it'd be great to merge and release a new extension with it, if that's fine with you 🙏 We'll probably have to look into how we can automate the publishing process, so that it's not on you everytime. Thanks @kanej!

@kanej
Copy link
Member

kanej commented May 7, 2024

Great, thanks!

Do I understand correctly that the lockfile version bumps for the extension in b268c5f are expected? I ran npm install after bumping the slang dep but it looked like the extension version needed updating as well.

If that's expected, it'd be great to merge and release a new extension with it, if that's fine with you 🙏 We'll probably have to look into how we can automate the publishing process, so that it's not on you everytime. Thanks @kanej!

They are expected. @OmarTawfik and I are planning on a release on Wed 7th May (tomorrow).

@kanej kanej merged commit 745c88a into NomicFoundation:development May 8, 2024
9 of 10 checks passed
OmarTawfik pushed a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants