Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set baseBranch=development in .changeset/config.json #532

Closed
wants to merge 1 commit into from

Conversation

OmarTawfik
Copy link
Contributor

cc @kanej

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our current publishing instructions are not leveraging changeset (our current changelog is based on Keep a changelog format, which isn't supported).

The publish instructions under ./docs/publish-extension.md suggest opening a release branch against main when putting together the release commit. It is at that point, I typically compare any changesets that have been added and update the changelog manually - hence the baseBranch of main.

My intent was to switch to a full changeset setup with automatic release from github ci on PR merge into main. But that remains an intention currently.

I am happy to see the changeset base branch changed to development if you are more comfortable putting together the release commit on development.

@OmarTawfik
Copy link
Contributor Author

I looked at the instructions you sent, and it appears that CD involves multiple steps with secrets/env setup. I was just trying to unblock running changeset locally, but it seems there are a few other things that need to be done as well. I would rather not update/change anything right now, and risk breaking the pipeline, so I will leave it for now.

@OmarTawfik OmarTawfik closed this Dec 1, 2023
@OmarTawfik OmarTawfik deleted the OmarTawfik/fix-changesets branch December 1, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants