Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid directories ending in .sol #285

Merged
merged 2 commits into from
Nov 24, 2022
Merged

fix: avoid directories ending in .sol #285

merged 2 commits into from
Nov 24, 2022

Conversation

antico5
Copy link
Collaborator

@antico5 antico5 commented Nov 23, 2022

No description provided.

@antico5 antico5 requested a review from kanej November 23, 2022 14:13
@kanej
Copy link
Member

kanej commented Nov 24, 2022

What are the reproduction steps for the bug this resolves?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (development@6b5d483). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             development     #285   +/-   ##
==============================================
  Coverage               ?   57.56%           
==============================================
  Files                  ?      173           
  Lines                  ?     4263           
  Branches               ?      697           
==============================================
  Hits                   ?     2454           
  Misses                 ?     1579           
  Partials               ?      230           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to confirm the error doesn't appear in local testing.

@kanej kanej merged commit 8b4308c into development Nov 24, 2022
@kanej kanej deleted the fix-sol-dir-error branch November 24, 2022 15:23
@kanej kanej mentioned this pull request Nov 24, 2022
kanej added a commit that referenced this pull request Nov 24, 2022
* fix: avoid directories ending in .sol

* test: fix missing `isFile` in test mocks

Co-authored-by: John Kane <john@kanej.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants