Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting of comments doesn't work inside an enum #165

Closed
fvictorio opened this issue Apr 25, 2022 · 1 comment · Fixed by #166
Closed

Syntax highlighting of comments doesn't work inside an enum #165

fvictorio opened this issue Apr 25, 2022 · 1 comment · Fixed by #166
Assignees
@kanej

Comments

@fvictorio
Copy link
Member

Code:

enum MyEnum {
    VALUE, // comment
    ANOTHER_VALUE /* another comment */
}

How it's shown in vscode:

image

Notice that comments don't have the right color.
@github-actions
Copy link

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: 29f058de-bbb2-4e27-b16b-cf2b2545e59d

kanej added a commit that referenced this issue Apr 26, 2022
@kanej
feat(syntax): allow comments in enums
71048d1 
Include the comment pattern in both enum declaration and function
argument lists.

Fixes #165.
@kanej kanej mentioned this issue Apr 26, 2022
Merged
@kanej kanej linked a pull request Apr 26, 2022 that will close this issue
feat(syntax): allow comments in enums #166
Merged
kanej added a commit that referenced this issue Apr 28, 2022
@kanej
feat(syntax): allow comments in enums (#166)
2daa63d 
Include the comment pattern in both enum declaration, function
argument lists and function modifier lists.

Fixes #165.
@kanej kanej mentioned this issue Apr 29, 2022
Merged
@kanej kanej closed this as completed in e4411e0 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(syntax): allow comments in enums NomicFoundation/hardhat-vscode
2 participants
@kanej @fvictorio