ci: upload Hardhat-tests coverage to Codecov - #1388
Merged
Merged
Conversation
|
nebasuke
had a problem deploying
to
github-action-benchmark
May 6, 2026 18:32 — with 
GitHub Actions
Error
GitHub Actions
Error
nebasuke
force-pushed
the
ci/codecov-disable-search
branch
from
May 6, 2026 18:34
ef7e7d4 to
b8963bf
Compare
nebasuke
temporarily deployed
to
github-action-benchmark
May 6, 2026 18:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
nebasuke
temporarily deployed
to
github-action-benchmark
May 6, 2026 18:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
nebasuke
had a problem deploying
to
github-action-benchmark
May 6, 2026 18:35 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 74.41% 79.27% +4.85%
==========================================
Files 444 444
Lines 76051 76051
Branches 76051 76051
==========================================
+ Hits 56597 60293 +3696
+ Misses 17462 13630 -3832
- Partials 1992 2128 +136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebasuke
changed the title
The hardhat-tests workflow already ran `cargo llvm-cov report` against the JS test run, but the resulting `codecov.json` was never uploaded. Hardhat-tests is the suite that exercises the napi binding code paths end-to-end (subscriptions, providers, Solidity test runs, stack-trace decoding), so dropping its report leaves those files looking under-covered on every PR. Add the Codecov upload step matching the pattern used in edr-ci.yml.
nebasuke
force-pushed
the
ci/codecov-disable-search
branch
from
May 6, 2026 23:33
b8963bf to
adea231
Compare
nebasuke
temporarily deployed
to
github-action-benchmark
May 6, 2026 23:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
nebasuke
temporarily deployed
to
github-action-benchmark
May 6, 2026 23:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
nebasuke
temporarily deployed
to
github-action-benchmark
May 6, 2026 23:35 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
nebasuke
marked this pull request as ready for review
May 6, 2026 23:46
popescuoctavian
approved these changes
May 7, 2026
popescuoctavian
left a comment
popescuoctavian
left a comment
Contributor
There was a problem hiding this comment.
Great find, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
hardhat-testsworkflow already runscargo llvm-cov reportafter the JS test run and produces acodecov.json, but it never had an upload step — the file was generated and discarded. That suite exercises the napi binding code paths end-to-end (subscriptions, provider lifecycles, Solidity test runs, stack-trace decoding), so without its upload those files look under-covered on every PR even though they are tested.Most visible on #1385 (napi v3 migration): patch coverage 52% with
call_override.rs,provider.rs, andtrace/debug.rsshowing 0% — exactly the files Hardhat-tests would cover.Change
Add a
codecov-actionupload step tohardhat-tests.ymlaftercargo llvm-cov report, matching the pattern already used by the three uploads inedr-ci.yml(matrix-named, SHA-pinned,fail_ci_if_error: false,CODECOV_TOKEN).