Added quick Docker demo. #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #### Handle long-living / daemon processes | ||
|
|
||
| If your CLI script is long-living and/or daemonized (e.g. via supervisord), profiling its whole lifespan could be meaningless. This is especially true in case of a service waiting for tasks to process. |
There was a problem hiding this comment.
is it an intentional change ?
There was a problem hiding this comment.
Looks like automated trailing-space cleanup to me… I never got that "double space at the end for a linebreak" thing in Markdown, too error-prone IMHO.
| * PHP 5.4 to 8.3 | ||
| * Non-ZTS (threaded) build of PHP (ZTS support is theoretical) | ||
|
|
||
| ## Quick demo in Docker |
There was a problem hiding this comment.
Suggested change
| ## Quick demo in Docker | |
| ## Quick demo using Docker |
kdambekalns
reviewed
Aug 8, 2025
Comment on lines
+212
to
+213
| If your CLI script is long-living and/or daemonized (e.g. via supervisord), profiling its whole lifespan could be meaningless. This is especially true in case of a service waiting for tasks to process. | ||
| To handle this case, SPX allows to disable the automatic start of profiling and exposes 2 userland functions, `spx_profiler_start(): void` & `spx_profiler_stop(): ?string`, in order to respectively control the start and the end of the profiled spans. |
There was a problem hiding this comment.
Suggested change
| If your CLI script is long-living and/or daemonized (e.g. via supervisord), profiling its whole lifespan could be meaningless. This is especially true in case of a service waiting for tasks to process. | |
| To handle this case, SPX allows to disable the automatic start of profiling and exposes 2 userland functions, `spx_profiler_start(): void` & `spx_profiler_stop(): ?string`, in order to respectively control the start and the end of the profiled spans. | |
| If your CLI script is long-living and/or daemonized (e.g. via supervisord), profiling its whole lifespan could be meaningless. This is especially true in case of a service waiting for tasks to process. | |
| To handle this case, SPX allows to disable the automatic start of profiling and exposes 2 userland functions, `spx_profiler_start(): void` & `spx_profiler_stop(): ?string`, in order to respectively control the start and the end of the profiled spans. |
|
|
||
| #### Handle long-living / daemon processes | ||
|
|
||
| If your CLI script is long-living and/or daemonized (e.g. via supervisord), profiling its whole lifespan could be meaningless. This is especially true in case of a service waiting for tasks to process. |
There was a problem hiding this comment.
Looks like automated trailing-space cleanup to me… I never got that "double space at the end for a linebreak" thing in Markdown, too error-prone IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#211
#201