Vault edition: Use Streams instead of Buffers #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for writing files and notes to the vault using streamed content. The `IWritableVault` interface now includes two new methods: `WriteFileAsync(string path, Stream content)` and `WriteNoteAsync(string path, Stream content)`. These methods allow creating or overwriting files and notes with the specified path, while also accepting a stream of content. In the implementation of the `FileSystemVault` class, these methods have been implemented to write the streamed content to the file system. The existing method signatures that accept byte arrays have been updated to internally use streams for consistency. Additionally, some code cleanup has been done by removing unused namespaces and renaming a utility class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
IWritableVaultinterface to mandate streams. Buffer implementations are moved to an extension class.