Skip to content

feat(warnings): add new severity property to warnings #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mathieuka
Copy link
Contributor

@Mathieuka Mathieuka commented May 9, 2022

Issue #26

We add a new severity property for each warning:

  • Information (For things not related to security, with valid values or a lot of false positive).
  • Warning (the default).
  • Critical (Implies malicious code or intent).

@Mathieuka Mathieuka force-pushed the add-a-severity-property-to-warnings branch from 58a1f42 to dec32ce Compare May 9, 2022 11:53
@Mathieuka Mathieuka changed the title feat(warnings): add new severity property to warnings feat(warnings): add new severity property to warnings May 9, 2022
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (Even if I cannot judge the severity tier myself, @fraxken will ^^)

Just a note: could you provide a bit of context in the description field please?

@fraxken fraxken merged commit 2dbf792 into NodeSecure:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants