fs-constants@1.0.0 index.js detected as minified

[fraxken]

The following file is detected as minified: https://unpkg.com/fs-constants@1.0.0/index.js

expected: should not be detected as a minified file

[jean-michelet]

Looking into it.

[jean-michelet]

It comes from the library is-minified-code...

I logged here:

js-x-ray/index.js

Line 67 in 5273190

const isMin = filePathString.includes(".min") || isMinified(str);

I think one line file expressions are considered minified by default.

Considered minified:

module.exports = require('fs').constants || require('constants')

Considered NOT minified:

module.exports = require('fs').constants 
|| require('constants')

Why is it a big deal?

[fraxken]

@jean-michelet Nothing crazy, it just report the file as minified when not in the CLI (false positive).

Yes is-minified-code is not perfect, last time @PierreDemailly was sharing another package but it has downside too.

[PierreDemailly]

Yeah, didn't find a more accurate lib unfortunately.
May we could check for a minimum length if the file is one line ? Something like isMinified(str) && (str.split(/\r?\n/).length > 1 ? true : str.length > 200) ?

[jean-michelet]

@PierreDemailly

I think that the problem is that the definition of minified is not related to a minimum length, right?
I think it could lead to similar issues in the future, if not now?

Maybe we could decide for an imperfect (if not possible to do better), but consistent behavior between CLI and js-x-ray regarding minification.

[jean-michelet]

This one can be closed