Skip to content

feat(contacts): highlight contacts #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

clemgbld
Copy link
Contributor

@clemgbld clemgbld commented Jun 9, 2025

Closes #490

@clemgbld clemgbld force-pushed the feat/highlight-contacts branch from 89af2d4 to 61fe812 Compare June 9, 2025 10:04
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 60.78431% with 20 lines in your changes missing coverage. Please review.

Project coverage is 73.38%. Comparing base (28ee6a9) to head (ec6c0f4).
Report is 191 commits behind head on master.

Files with missing lines Patch % Lines
src/commands/scanner.js 4.76% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##            master     #504       +/-   ##
============================================
- Coverage   100.00%   73.38%   -26.62%     
============================================
  Files           15       38       +23     
  Lines          649     2728     +2079     
  Branches         0        1        +1     
============================================
+ Hits           649     2002     +1353     
- Misses           0      726      +726     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clemgbld clemgbld force-pushed the feat/highlight-contacts branch from 61fe812 to b7e356a Compare June 9, 2025 10:21
Comment on lines 91 to 93
{ maxDepth, highlight: {
contacts: parseContacts(contacts)
} },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ maxDepth, highlight: {
contacts: parseContacts(contacts)
} },
{
maxDepth,
highlight: {
contacts: parseContacts(contacts)
}
},

@clemgbld clemgbld force-pushed the feat/highlight-contacts branch from 5dcd678 to c366130 Compare June 13, 2025 17:04
@fraxken
Copy link
Member

fraxken commented Jun 13, 2025

image

Tested to highlight myself but look like it doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight contacts
2 participants