labels for network edges #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow you'r onfire 😍. Maybe parent/child ? When there is to much nodes I feel like we don't properly differentiate Dependency and Dependent. |
Contributor
Author
|
@fraxken any thoughts on showing label when only one edge is selected..? It is feasible to modify its label, but i am not sure if its really useful..? currently it always says child of assuming user is following the arrow from parent node to child |
Member
|
@kishore881 Hmm I personnaly never select edges. So yeah probably not useful. |
kishore881
commented
Dec 4, 2023
fraxken
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #284
Feel free to suggest alternate labels for when a node is selected and if edges should have a label at all when only the edge is selected but not the node
After changes:
Screen.Recording.2023-12-04.at.9.46.57.PM.mov