Migration from size-satisfies to workspaces #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabnguess
force-pushed
the
migrate_size_satisfies_cli_workspaces
branch
from
7fc7f05 to
0b25dbf
Compare
Member
|
It look like you deleted vis-network ? I don't think we wanna git submodule, just copy/paste package in /workspaces, update package.json#workspaces, update links in package.json & README and add size-satisfies GA workflow |
fabnguess
force-pushed
the
migrate_size_satisfies_cli_workspaces
branch
from
0b25dbf to
52b9fb3
Compare
Member
|
Also don't forget to update https://github.com/NodeSecure/cli#workspaces |
fabnguess
force-pushed
the
migrate_size_satisfies_cli_workspaces
branch
from
52b9fb3 to
349c1f6
Compare
fabnguess
force-pushed
the
migrate_size_satisfies_cli_workspaces
branch
from
349c1f6 to
68e3294
Compare
PierreDemailly
approved these changes
Dec 3, 2023
fraxken
requested changes
Dec 4, 2023
fabnguess
force-pushed
the
migrate_size_satisfies_cli_workspaces
branch
from
68e3294 to
692566b
Compare
fraxken
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.