Add lookup endpoint for external services to find users by their own id #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brutus5000
force-pushed
the
feature/user-lookup
branch
from
2406d5c to
ab550b8
Compare
|
@julianlam Any feedback? |
barisusakli
reviewed
Mar 5, 2025
| const userId = await main.getUidByOAuthid(req.params.provider, req.params.oAuthId); | ||
| if (!userId) { | ||
| helpers.formatApiResponse(404, res); | ||
| } |
There was a problem hiding this comment.
Alternatively, you can return next() in order to invoke the regular api 404 handler. You'll have to add next to the method parameters.
julianlam
reviewed
Mar 6, 2025
README.md
Outdated
|
|
||
| ### API | ||
| If you need to look up the user from your own system, you can use the GET api route `oauth2-multiple/provider/:provider/user/:oAuthId`. |
There was a problem hiding this comment.
May as well provide the full prefix: /api/v3/plugins/oauth2-multiple...
julianlam
requested changes
Mar 6, 2025
Brutus5000
force-pushed
the
feature/user-lookup
branch
from
ab550b8 to
61bf27b
Compare
julianlam
approved these changes
Mar 10, 2025
|
v1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.