-
Notifications
You must be signed in to change notification settings - Fork 4
first attempt to nicer foldmarks #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change adds custom visual indicators for code folds in Neovim by configuring the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the fold marks configuration in the nvim-ufo plugin setup by customizing the fold display characters to use Unicode box-drawing characters for a more visually appealing fold indicator presentation.
- Adds custom fold character configuration using Unicode symbols
- Documents a preferred alternative character for future consideration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| vim.o.foldenable = true | ||
|
|
||
| vim.o.fillchars = "foldopen:╭,foldclose:·,foldsep:│" | ||
| -- prefered "tail": ╰ |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "prefered" should be "preferred".
| -- prefered "tail": ╰ | |
| -- preferred "tail": ╰ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plugins/nobbz/lua/nobbz/ufo.lua (1)
6-8: Refinefillcharscustomization and fix tiny typoRight now
vim.o.fillcharsis fully overwritten, which can unintentionally drop otherfillcharsyou might have set elsewhere (e.g.eob,vert,diff). If you only want to tweak the fold-related characters, consider appending instead of replacing, and fix the spelling in the comment:-vim.o.fillchars = "foldopen:╭,foldclose:·,foldsep:│" --- prefered "tail": ╰ +vim.opt.fillchars:append({ + foldopen = "╭", + foldclose = "·", + foldsep = "│", +}) +-- preferred "tail": ╰This keeps any existing non-fold
fillcharswhile still giving you the custom fold markers you want, and cleans up the comment wording.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
plugins/nobbz/lua/nobbz/ufo.lua(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
plugins/**/*.lua
⚙️ CodeRabbit configuration file
plugins/**/*.lua: Please ensure all of the following:
- Plugins are lazyloaded if possible through
nobbz.lazylocalhas to be used- coding follows the luarocks styleguide, but with 2 spaces indentation
Files:
plugins/nobbz/lua/nobbz/ufo.lua
🧠 Learnings (1)
📓 Common learnings
Learnt from: NobbZ
Repo: NobbZ/nobbz-vim PR: 0
File: :0-0
Timestamp: 2025-04-12T09:24:45.451Z
Learning: NobbZ uses a homebrewn shallow abstraction over `lz.n` rather than using lazy.nvim directly. References to Lazy.nvim's specific features should be avoided in reviews of NobbZ's repository.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.