Skip to content

Conversation

@NobbZ
Copy link
Owner

@NobbZ NobbZ commented Nov 3, 2025

Summary by CodeRabbit

  • Chores
    • Updated source configuration for nvim-nvim-ufo and nvim-nui packages with new tracking parameters.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

Two Neovim plugin entries in the pins configuration are converted from GitRelease-based tracking to Git branch-based tracking. Their types are changed, release-related fields are removed, and metadata is updated with new revisions and hashes targeting the "main" branch.

Changes

Cohort / File(s) Summary
Dependency source migration
npins/sources.json
Converted "nvim-nvim-ufo" and "nvim-nui" entries from GitRelease to Git type; removed pre_releases, version_upper_bound, and release_prefix fields; added branch field set to "main"; updated revision, url, and hash references

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Both entries follow an identical pattern of changes, reducing cognitive load
  • Configuration-only modifications with no logic or structural complexity
  • Straightforward metadata updates and field removals

Possibly related PRs

  • update 2025-05-05 #64: Updates the pinned metadata for the "nvim-nui" entry with matching revision/url/hash changes.
  • set up UFO #41: Modifies the "nvim-nvim-ufo" entry in the same sources file; this PR changes it from GitRelease to Git type.
  • update 2025-04-13 #57: Updates the nvim-ufo entry revision/url/hash values alongside type and field modifications.

Poem

🐰 From releases we hop to branches new,
"main" awaits both nui and ufo too!
With fresher pins and cleaner ways,
Our config blooms through autumn days. 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions updating 'nvim-ufo' to fix folding issues, but the changeset actually updates TWO packages: 'nvim-nvim-ufo' AND 'nvim-nui', converting both from GitRelease to Git type. The title only references one package and omits the nvim-nui update. Revise the title to reflect all packages being updated, such as 'update nvim-ufo and nvim-nui to use Git type' or provide context about both changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch push-qsoppprzvyxy

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c86af5d and b44ff11.

📒 Files selected for processing (1)
  • npins/sources.json (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: NobbZ
Repo: NobbZ/nobbz-vim PR: 0
File: :0-0
Timestamp: 2025-04-12T09:24:45.451Z
Learning: NobbZ uses a homebrewn shallow abstraction over `lz.n` rather than using lazy.nvim directly. References to Lazy.nvim's specific features should be avoided in reviews of NobbZ's repository.
🔇 Additional comments (2)
npins/sources.json (2)

308-323: Inconsistency: Summary claims nvim-nui was changed, but provided code shows no changes.

The AI summary states that the nvim-nui entry was converted from GitRelease to Git type with branch set to "main", but the annotated code shows no change markers (~) on this entry. The provided code still shows:

  • "type": "GitRelease"
  • "version": "0.4.0"
  • Release-related fields intact

Please clarify whether nvim-nui should also be updated as part of this PR, or if the summary is inaccurate.


325-325: Confirm intentionality: Migration from GitRelease to Git branch tracking for nvim-ufo.

The changes convert nvim-nvim-ufo from release-based (GitRelease type) to branch-based (Git type on main) tracking. This means the package will now pull the latest development commits rather than stable releases.

Please confirm:

  1. This migration is intended to fix the folding issues mentioned in the PR title
  2. You're aware this tracks unstable/in-development code and may introduce breaking changes in future updates
  3. Whether the new revision hash (72d54c31079d38d8dfc5456131b1d0fb5c0264b0) is known to include the necessary folding fixes

Also applies to: 331-331, 333-335


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NobbZ NobbZ merged commit 056e422 into main Nov 3, 2025
3 checks passed
@NobbZ NobbZ deleted the push-qsoppprzvyxy branch November 3, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants