Skip to content

Conversation

@NobbZ
Copy link
Owner

@NobbZ NobbZ commented Oct 31, 2025

Summary by CodeRabbit

  • Chores
    • Refreshed pinned source dependencies with updated versions and metadata to latest available snapshots.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Walkthrough

This PR updates multiple pinned Git source entries in npins/sources.json, refreshing revision hashes, download URLs, and version metadata across numerous dependencies. The changes maintain existing branching and submodule settings while replacing resolved source identifiers with current values.

Changes

Cohort / File(s) Summary
Pinned source metadata refresh
npins/sources.json
Updated revision hashes, URLs, and version strings for multiple Git sources; some entries converted to GitRelease-style patterns; no schema changes to control flow or dependencies

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Focus on verifying that revision hashes match their corresponding Git repository commits
  • Confirm all URL changes point to valid, intended repository locations
  • Spot-check a few GitRelease-style conversions to ensure metadata patterns are consistent

Possibly related PRs

  • update 2025-04-06 #50: Updates the same npins/sources.json entries with refreshed revisions/URLs/hashes for pinned Git sources
  • update 2025-04-13 #57: Modifies npins/sources.json entries by updating Git source revisions, URLs, and hashes with overlapping changes
  • update 2025-05-19 #65: Direct overlapping edits to npins/sources.json, updating pinned Git sources' revision hashes, download URLs, and version metadata

Poem

🐰 A fresh batch of sources, all polished and bright,
Revisions and hashes aligned just right!
With URLs pointing true and versions set clean,
Our dependencies now are the newest they've been. ✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title "update flake.lock" claims to update the flake.lock file, but the actual changes are entirely within npins/sources.json, which contains pinned Git source metadata (revisions, URLs, hashes). While both files relate to dependency management in a Nix environment, they are distinct files serving different purposes, making the title misleading and not aligned with the actual changeset being introduced. The title should be updated to accurately reflect the changes being made, such as "update npins/sources.json" or "update pinned sources" to clearly communicate that the changes involve refreshing source pins and metadata rather than modifying the flake.lock lockfile.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-2025-10-31

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 379188b and 30aa2b8.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • npins/sources.json (17 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: NobbZ
Repo: NobbZ/nobbz-vim PR: 0
File: :0-0
Timestamp: 2025-04-12T09:24:45.451Z
Learning: NobbZ uses a homebrewn shallow abstraction over `lz.n` rather than using lazy.nvim directly. References to Lazy.nvim's specific features should be avoided in reviews of NobbZ's repository.
📚 Learning: 2025-04-12T09:24:45.451Z
Learnt from: NobbZ
Repo: NobbZ/nobbz-vim PR: 0
File: :0-0
Timestamp: 2025-04-12T09:24:45.451Z
Learning: NobbZ uses a homebrewn shallow abstraction over `lz.n` rather than using lazy.nvim directly. References to Lazy.nvim's specific features should be avoided in reviews of NobbZ's repository.

Applied to files:

  • npins/sources.json
🔇 Additional comments (1)
npins/sources.json (1)

1-462: Lock file structure and formatting are valid.

Programmatic validation confirms all 34 pins are properly formatted with required fields present: type, revision (40-char SHA1), url (properly constructed), and hash (Nix base32 format). All entries follow the npins schema consistently.

However, verification of actual Git commits and Nix hash correctness requires the npins tool and cannot be completed in this environment. Confirm the update with:

cd npins && npins check && npins verify

This ensures all pinned revisions exist and the hashes resolve correctly.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NobbZ NobbZ requested a review from Copilot October 31, 2025 16:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates multiple dependencies to their latest versions, including Neovim plugins, language servers, and Nix flake dependencies.

  • Updates 18 dependency entries in npins/sources.json with new revision hashes and URLs
  • Updates nixpkgs and flake-parts lock entries in flake.lock

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
npins/sources.json Updates revision hashes, URLs, and content hashes for 18 Neovim plugins and tools including EmmyLuaCodeStyle, markdown-oxide, neovim, nvim-augment, nvim-catppuccin, nvim-flash, nvim-gitsigns, nvim-ledger, nvim-lspconfig, nvim-luasnip, nvim-lz-n, nvim-mini, nvim-none-ls, nvim-rainbow-delimiters, nvim-surround, nvim-trouble, and nvim-which-key
flake.lock Updates nixpkgs and flake-parts dependencies with new commit hashes and timestamps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NobbZ NobbZ merged commit c86af5d into main Oct 31, 2025
9 checks passed
@NobbZ NobbZ deleted the update-2025-10-31 branch October 31, 2025 16:38
@coderabbitai coderabbitai bot mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants