blink tweaks

[NobbZ]

• replace hardcoded string with variable that has same value
• use highlight fallback for compatibility

Summary by CodeRabbit

• New Features

  • Added configuration option for completion plugin appearance
  • Enhanced customization of documentation display settings

• Refactor

  • Improved code maintainability by centralizing window highlight configuration

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the Lua configuration for a blink completion plugin. The changes introduce a new appearance configuration option with a use_nvim_cmp_as_default boolean setting. Additionally, the winhighlight property in the documentation section is refactored to use a predefined variable instead of a hardcoded string, improving code maintainability and flexibility.

Changes

File	Change Summary
plugins/nobbz/lua/nobbz/blink.lua	- Added appearance configuration with use_nvim_cmp_as_default option - Refactored winhighlight to use a variable reference

Poem

🐰 A Rabbit's Ode to Blink Config 🌟

With nvim-cmp now set to default,
And highlights dancing with grace,
Our config leaps with newfound spark,
A cleaner, brighter coding space!

Hop, hop, configuration bright! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

plugins/nobbz/lua/nobbz/blink.lua (1)

4-6: Consider adding documentation for the new appearance option.

The use_nvim_cmp_as_default setting appears to implement the highlight fallback mentioned in the PR objectives. Consider adding a comment explaining what this option controls and its impact on the completion menu appearance.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f84bb3 and fb38047.

📒 Files selected for processing (1)

• plugins/nobbz/lua/nobbz/blink.lua (2 hunks)

🔇 Additional comments (2)

plugins/nobbz/lua/nobbz/blink.lua (2)

1-1: Good refactoring of the winhighlight string!

Extracting the highlight groups into a variable improves maintainability and reduces duplication. The chosen highlight groups (NormalFloat, FloatBorder, PmenuSel) are appropriate for completion windows.

---

34-34: Good consistency in highlight configuration!

Using the same winhighlight variable for both completion menu and documentation windows ensures visual consistency in the UI.