Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public Observable alias to overcome Xcode 15 bug #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johankool
Copy link

@johankool johankool commented Sep 18, 2023

Fixes #66

@DmitriyAnd
Copy link

@freak4pc Hi!
Is there any way you can merge this or #68 PRs and publish updated version for Cocoapods?
Thanks

iandric

This comment was marked as outdated.

@@ -9,6 +9,8 @@
import RxCocoa
import RxSwift

public typealias Observable = RxSwift.Observable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make more sense to put this in a separate file, e.g. named Observable+Alias.swift? WDYT?

@AboulEinein
Copy link

@iandric any idea when will this be merged and a new release published? I'm currently blocked by this 🙏🏻

@iandric
Copy link

iandric commented Sep 21, 2023

@iandric any idea when will this be merged and a new release published? I'm currently blocked by this 🙏🏻

No, I'm not involved in the project; just tried to speed things up by reviewing and bumping this.

@freak4pc
Copy link
Collaborator

There's no active maintainer for this project unfortunately. I can try and help in a few days but am preoccupied at the moment 🙏

@iandric
Copy link

iandric commented Sep 21, 2023

There's no active maintainer for this project unfortunately. I can try and help in a few days but am preoccupied at the moment 🙏

Gotcha @freak4pc, just created a new PR handling this, that also fixes Example app compilation. Also raised version to 4.0.1, so maybe that one could possibly be the one to get this fix merged?

@brandy2015
Copy link

private func bindingsStrongify<Event, O, WeakOwner>(_ owner: WeakOwner, _ bindings: @escaping (WeakOwner, O) -> (Bindings))
-> (O) -> (Bindings) where WeakOwner: AnyObject {
return { [weak owner] state -> Bindings in
guard let strongOwner = owner else {

            return Bindings(subscriptions: [], events:  [Observable<Event>]())
        }
        return bindings(strongOwner, state)
    }

}

//Add this to Fix it
public typealias Observable = RxSwift.Observable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Xcode 15 RC1 Bag] Names conflict
6 participants